diff options
author | Hind-M <hind.montassif@gmail.com> | 2022-01-31 11:15:54 +0100 |
---|---|---|
committer | Hind-M <hind.montassif@gmail.com> | 2022-01-31 11:15:54 +0100 |
commit | 1209db091a89ed48527c34fff0cc9ef41c78d11f (patch) | |
tree | e34a11454579e27ad3c711b50a46c5c9670a3e54 /.github/for_maintainers | |
parent | 8d1e7aeb3416194d00f45587d1ecea85ba218028 (diff) | |
parent | 7f1b8eb706c72921141b53e607d6e2aa28e2bf19 (diff) |
Merge remote-tracking branch 'upstream/master' into fetch_datasets
Diffstat (limited to '.github/for_maintainers')
-rw-r--r-- | .github/for_maintainers/tests_strategy.md | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/.github/for_maintainers/tests_strategy.md b/.github/for_maintainers/tests_strategy.md index 2bba3f42..338d4282 100644 --- a/.github/for_maintainers/tests_strategy.md +++ b/.github/for_maintainers/tests_strategy.md @@ -8,7 +8,7 @@ The aim is to help maintainers to anticipate third parties modifications, update ### Linux -As all the third parties are already installed (thanks to docker), the compilations has been separated by categories to be parallelized: +As all the third parties are already installed (thanks to docker), the compilations have been separated in categories to be parallelized: * examples (C++) * tests (C++) @@ -25,9 +25,9 @@ Without CGAL, and, with or without Eigen builds are performed inside the docker #### Update docker images -C++ third parties installation are done thanks to apt on Ubuntu latest LTS. +C++ third parties installation is done thanks to apt on Ubuntu latest LTS. -Docker images need to be rebuild and push each time `.github/build-requirements`, `.github/test-requirements`, when a new third party is added, when a new CGAL version improves gudhi performances, ... +Docker images need to be rebuilt and pushed each time `.github/build-requirements`, `.github/test-requirements`, when a new third party is added, when a new CGAL version improves gudhi performances, ... ```bash docker build -f Dockerfile_for_circleci_image -t gudhi/ci_for_gudhi:latest . @@ -39,22 +39,24 @@ docker push gudhi/ci_for_gudhi_wo_cgal:latest ### Windows -The compilations has been separated by categories to be parallelized, but I don't know why builds are not run in parallel: +The compilations are not parallelized, as installation time (about 30 minutes) is too much compared to +build and tests timings (about 30 minutes). Builds and tests include: * examples (C++) * tests (C++) * utils (C++) * python (here the WITH_GUDHI_REMOTE_TEST option is enabled which adds datasets fetching test) -Doxygen (C++) is not tested. -(cf. `.appveyor.yml`) +Doxygen (C++) is not generated. +(cf. `azure-pipelines.yml`) -C++ third parties installation are done thanks to [vcpkg](https://github.com/microsoft/vcpkg/). -In case of installation issue, check in [vcpkg issues](https://github.com/microsoft/vcpkg/issues). +C++ third parties installation is done thanks to [vcpkg](https://github.com/microsoft/vcpkg/). +In case of an installation issue, check in [vcpkg issues](https://github.com/microsoft/vcpkg/issues). ### OSx -The compilations has been separated by categories to be parallelized: +The compilations are not parallelized, but they should, as installation time (about 4 minutes) is +negligible compared to build and tests timings (about 30 minutes). Builds and tests include: * examples (C++) * tests (C++) @@ -64,8 +66,8 @@ The compilations has been separated by categories to be parallelized: (cf. `azure-pipelines.yml`) -C++ third parties installation are done thanks to [brew](https://formulae.brew.sh/formula/). -In case of installation issue, check in formula issues. +C++ third parties installation is done thanks to [brew](https://formulae.brew.sh/formula/). +In case of an installation issue, check in formula issues. ## Pip packaging @@ -78,9 +80,9 @@ Only the Linux pip package is based on a docker image (`gudhi/pip_for_gudhi` bas ### Update docker image -C++ third parties installation are done thanks to yum on an image based on `quay.io/pypa/manylinux2014_x86_64`. +C++ third parties installation is done thanks to yum on an image based on `quay.io/pypa/manylinux2014_x86_64`. -Docker image need to be rebuild and push each time `.github/build-requirements`, when a new third party is added, when a new CGAL version improves gudhi performances, ... +Docker image needs to be rebuilt and pushed each time `.github/build-requirements`, when a new third party is added, when a new CGAL version improves gudhi performances, ... As `.github/test-requirements` is not installed, no need to rebuild image when this file is modified. ```bash |