Merge pull request #449 from VincentRouvreau/move_dockerfiles_in_another_repo

Move dockerfiles in another repo

8 files changed, 19 insertions, 21 deletions

diff --git a/.github/for_maintainers/new_gudhi_version_creation.md b/.github/for_maintainers/new_gudhi_version_creation.md
index 4de81b8a..aadfae7d 100644
--- a/.github/for_maintainers/new_gudhi_version_creation.md
+++ b/.github/for_maintainers/new_gudhi_version_creation.md
@@ -90,7 +90,8 @@ ln -s @GUDHI_VERSION@ latest
 
 ## Pip package
 
-The pip package construction shall be started on release creation, you just have to check [gudhi github actions](https://github.com/GUDHI/gudhi-devel/actions) results.
+The pip package construction shall be started on release creation, you just have to check
+[gudhi github actions](https://github.com/GUDHI/gudhi-devel/actions) results.
 The version number must be conform to [pep440](https://www.python.org/dev/peps/pep-0440/#pre-releases)
 
 ## Conda package
@@ -105,28 +106,20 @@ If you need to update conda tools (conda-build, conda-smithy, ...), add a commen
 
 ## Docker image
 
-You have to modify the `Dockerfile_gudhi_installation` at the root of this repository in order to use the last release, cf. lines:
+You have to modify the
+[Dockerfile_gudhi_installation](https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_gudhi_installation)
+in gudhi-deploy repository in order to use the last release, cf. lines:
 ```
 ...
-RUN curl -LO "https://github.com/GUDHI/gudhi-devel/releases/download/tags%2Fgudhi-release-@GUDHI_VERSION@/gudhi.@GUDHI_VERSION@.tar.gz" \
-&& tar xf gudhi.@GUDHI_VERSION@.tar.gz \
-&& cd gudhi.@GUDHI_VERSION@ \
+ARG GUDHI_VERSION="3.X.X"
 ...
 ```
 
-Build and push images to docker hub:
-```
-docker build -f Dockerfile_gudhi_installation -t gudhi/latest_gudhi_version:@GUDHI_VERSION@ .
-docker run --rm -it gudhi/latest_gudhi_version:@GUDHI_VERSION@ 
-```
-
-***[Check there are no error with utils and python version]***
+After pushing the changes the docker image build will be automatically performed for
+[latest_gudhi_version](https://hub.docker.com/repository/docker/gudhi/latest_gudhi_version)
+docker image on docker hub.
 
-```
-docker tag gudhi/latest_gudhi_version:@GUDHI_VERSION@ gudhi/latest_gudhi_version:latest
-docker push gudhi/latest_gudhi_version:latest
-docker push gudhi/latest_gudhi_version:@GUDHI_VERSION@
-```
+***[Check there are no error]***
 
 ## Mail sending
 Send version mail to the following lists :
diff --git a/.github/how_to_use_github_to_contribute_to_gudhi.md b/.github/how_to_use_github_to_contribute_to_gudhi.md
index 747ca39b..738c1ce9 100644
--- a/.github/how_to_use_github_to_contribute_to_gudhi.md
+++ b/.github/how_to_use_github_to_contribute_to_gudhi.md
@@ -33,6 +33,9 @@ Hera, used for Wasserstein distance, is available on an external git repository.
 git submodule update --init
 ```
 
+[gudhi-deploy](https://github.com/GUDHI/gudhi-deploy) is used for Continuous Integration python
+requirements and will also be downloaded by the above command.
+
 ## Configuring a remote for a fork
 ```bash
 git remote add upstream https://github.com/GUDHI/gudhi-devel.git
diff --git a/.github/workflows/pip-build-linux.yml b/.github/workflows/pip-build-linux.yml
index cf8ddadf..726ed0d5 100644
--- a/.github/workflows/pip-build-linux.yml
+++ b/.github/workflows/pip-build-linux.yml
@@ -6,6 +6,7 @@ jobs:
   build:
     name: build pip wheels
     runs-on: ubuntu-latest
+    # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip
     container: gudhi/pip_for_gudhi
     steps:
       - uses: actions/checkout@v1
diff --git a/.github/workflows/pip-build-osx.yml b/.github/workflows/pip-build-osx.yml
index 50b8b09c..732e26af 100644
--- a/.github/workflows/pip-build-osx.yml
+++ b/.github/workflows/pip-build-osx.yml
@@ -22,7 +22,7 @@ jobs:
         run: |
           brew update || true
           brew install boost eigen gmp mpfr cgal || true
-          python -m pip install --user -r .github/build-requirements.txt
+          python -m pip install --user -r ext/gudhi-deploy/build-requirements.txt
           python -m pip install --user twine delocate
       - name: Build python wheel
         run: |
diff --git a/.github/workflows/pip-build-windows.yml b/.github/workflows/pip-build-windows.yml
index aacbbc52..d07e8c46 100644
--- a/.github/workflows/pip-build-windows.yml
+++ b/.github/workflows/pip-build-windows.yml
@@ -24,7 +24,7 @@ jobs:
           vcpkg upgrade --no-dry-run
           type c:/vcpkg/ports/cgal/portfile.cmake
           vcpkg install eigen3 cgal --triplet x64-windows
-          python -m pip install --user -r .github/build-requirements.txt
+          python -m pip install --user -r ext/gudhi-deploy/build-requirements.txt
           python -m pip list
       - name: Build python wheel
         run: |
diff --git a/.github/workflows/pip-packaging-linux.yml b/.github/workflows/pip-packaging-linux.yml
index 469c3b3b..95e8f034 100644
--- a/.github/workflows/pip-packaging-linux.yml
+++ b/.github/workflows/pip-packaging-linux.yml
@@ -8,6 +8,7 @@ jobs:
   build:
     name: build pip wheels
     runs-on: ubuntu-latest
+    # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip
     container: gudhi/pip_for_gudhi
     steps:
       - uses: actions/checkout@v1
diff --git a/.github/workflows/pip-packaging-osx.yml b/.github/workflows/pip-packaging-osx.yml
index 46441e65..56309b88 100644
--- a/.github/workflows/pip-packaging-osx.yml
+++ b/.github/workflows/pip-packaging-osx.yml
@@ -24,7 +24,7 @@ jobs:
         run: |
           brew update || true
           brew install boost eigen gmp mpfr cgal || true
-          python -m pip install --user -r .github/build-requirements.txt
+          python -m pip install --user -r ext/gudhi-deploy/build-requirements.txt
           python -m pip install --user twine delocate
       - name: Build python wheel
         run: |
diff --git a/.github/workflows/pip-packaging-windows.yml b/.github/workflows/pip-packaging-windows.yml
index 3a751486..a428eaba 100644
--- a/.github/workflows/pip-packaging-windows.yml
+++ b/.github/workflows/pip-packaging-windows.yml
@@ -26,7 +26,7 @@ jobs:
           vcpkg upgrade --no-dry-run
           type c:/vcpkg/ports/cgal/portfile.cmake
           vcpkg install eigen3 cgal --triplet x64-windows
-          python -m pip install --user -r .github/build-requirements.txt
+          python -m pip install --user -r ext/gudhi-deploy/build-requirements.txt
           python -m pip install --user twine
           python -m pip list
       - name: Build python wheel