diff options
author | vrouvrea <vrouvrea@636b058d-ea47-450e-bf9e-a15bfbe3eedb> | 2018-09-07 15:20:46 +0000 |
---|---|---|
committer | vrouvrea <vrouvrea@636b058d-ea47-450e-bf9e-a15bfbe3eedb> | 2018-09-07 15:20:46 +0000 |
commit | e361de9c520eb3e5d789099f4cdaf4fb0efdba63 (patch) | |
tree | 8f4de69d94ca342126fbe4924fc7f24771f91adc | |
parent | 35fee4017481fd3f62fceb76a1b2bc8cd0f15b95 (diff) |
Code review : Only one create_complex function with a default argument value
git-svn-id: svn+ssh://scm.gforge.inria.fr/svnroot/gudhi/branches/alpha_complex_3d_module_vincent@3876 636b058d-ea47-450e-bf9e-a15bfbe3eedb
Former-commit-id: 36c2f8ebf6f60d85613c3bad6fa95433780e13bc
-rw-r--r-- | src/Alpha_complex/include/gudhi/Alpha_complex_3d.h | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/src/Alpha_complex/include/gudhi/Alpha_complex_3d.h b/src/Alpha_complex/include/gudhi/Alpha_complex_3d.h index bf1aaa99..f6adda8d 100644 --- a/src/Alpha_complex/include/gudhi/Alpha_complex_3d.h +++ b/src/Alpha_complex/include/gudhi/Alpha_complex_3d.h @@ -421,12 +421,6 @@ public: } - template <typename SimplicialComplexForAlpha3d> - bool create_complex(SimplicialComplexForAlpha3d& complex) { - using Filtration_value = typename SimplicialComplexForAlpha3d::Filtration_value; - return create_complex(complex, std::numeric_limits<Filtration_value>::infinity()); - } - /** \brief Inserts all Delaunay triangulation into the simplicial complex. * It also computes the filtration values accordingly to the \ref createcomplexalgorithm * @@ -440,16 +434,18 @@ public: * @pre The simplicial complex must be empty (no vertices) * * Initialization can be launched once. + * */ - template <typename SimplicialComplexForAlpha3d> - bool create_complex(SimplicialComplexForAlpha3d& complex, - typename SimplicialComplexForAlpha3d::Filtration_value max_alpha_square) { + template <typename SimplicialComplexForAlpha3d, typename Filtration_value = + typename SimplicialComplexForAlpha3d::Filtration_value> + bool create_complex(SimplicialComplexForAlpha3d& complex, Filtration_value max_alpha_square = + std::numeric_limits<Filtration_value>::infinity()) { if (complex.num_vertices() > 0) { std::cerr << "Alpha_complex_3d create_complex - complex is not empty\n"; return false; // ----- >> } - using Filtration_value = typename SimplicialComplexForAlpha3d::Filtration_value; + //using Filtration_value = typename SimplicialComplexForAlpha3d::Filtration_value; using Complex_vertex_handle = typename SimplicialComplexForAlpha3d::Vertex_handle; using Alpha_shape_simplex_tree_map = std::map<Alpha_vertex_handle, Complex_vertex_handle>; |