diff options
author | MathieuCarriere <mathieu.carriere3@gmail.com> | 2020-02-02 15:23:03 -0500 |
---|---|---|
committer | MathieuCarriere <mathieu.carriere3@gmail.com> | 2020-02-02 15:23:03 -0500 |
commit | f2020f6bb3a4d2bbd774aa630151ef1db53ac4f8 (patch) | |
tree | 52cd4b5929bdb84f48d82f564ae2a093877f3caa /src/Simplex_tree | |
parent | 1dd1c554a962db70809eadb470eb2eaa733970d4 (diff) |
fixed Marc's comments
Diffstat (limited to 'src/Simplex_tree')
-rw-r--r-- | src/Simplex_tree/include/gudhi/Simplex_tree.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/Simplex_tree/include/gudhi/Simplex_tree.h b/src/Simplex_tree/include/gudhi/Simplex_tree.h index 4786b244..301f7aae 100644 --- a/src/Simplex_tree/include/gudhi/Simplex_tree.h +++ b/src/Simplex_tree/include/gudhi/Simplex_tree.h @@ -1471,7 +1471,7 @@ class Simplex_tree { * @param[in] dgm Persistence diagram obtained after calling this->extend_filtration and this->get_persistence. * @return A vector of four persistence diagrams. The first one is Ordinary, the second one is Relative, the third one is Extended+ and the fourth one is Extended-. */ - std::vector<std::vector<std::pair<int, std::pair<double, double>>>> convert(const std::vector<std::pair<int, std::pair<double, double>>>& dgm){ + std::vector<std::vector<std::pair<int, std::pair<double, double>>>> compute_extended_persistence_subdiagrams(const std::vector<std::pair<int, std::pair<double, double>>>& dgm){ std::vector<std::vector<std::pair<int, std::pair<double, double>>>> new_dgm(4); double x, y; for(unsigned int i = 0; i < dgm.size(); i++){ int h = dgm[i].first; double px = dgm[i].second.first; double py = dgm[i].second.second; if(std::isinf(py)) continue; @@ -1487,7 +1487,7 @@ class Simplex_tree { return new_dgm; } - /** \brief Extend filtration for computing extended persistence. + /** \brief Extend filtration for computing extended persistence. This function only uses the filtration values at the 0-dimensional simplices, and computes the extended persistence diagram induced by the lower-star filtration computed with these values. Note that after calling this function, the filtration values are actually modified. The function compute_extended_persistence_subdiagrams retrieves the original values and separates the extended persistence diagram points w.r.t. their types (Ord, Rel, Ext+, Ext-) and should always be called after computing the persistent homology of the extended simplicial complex. */ void extend_filtration() { |