diff options
author | ROUVREAU Vincent <vincent.rouvreau@inria.fr> | 2020-07-01 22:33:35 +0200 |
---|---|---|
committer | ROUVREAU Vincent <vincent.rouvreau@inria.fr> | 2020-07-01 22:33:35 +0200 |
commit | 54309849264b5f5ab61e11031044d135c0bb9aa5 (patch) | |
tree | 584f8e73318cfdfede26b47754f70a9edf53d1cb /src | |
parent | 7fb8f17638ee7245a1eb6c604c6629a484612179 (diff) |
Code review: let's use override as a good practice
Diffstat (limited to 'src')
-rw-r--r-- | src/python/include/Alpha_complex_factory.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/python/include/Alpha_complex_factory.h b/src/python/include/Alpha_complex_factory.h index b0e9dc93..d699ad9b 100644 --- a/src/python/include/Alpha_complex_factory.h +++ b/src/python/include/Alpha_complex_factory.h @@ -63,13 +63,13 @@ class Exact_Alphacomplex_dD : public Abstract_alpha_complex { alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal<Point>)) { } - std::vector<double> get_point(int vh) override { + virtual std::vector<double> get_point(int vh) override { Point const& point = alpha_complex_.get_point(vh); return pt_cgal_to_cython(point); } - bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, - bool default_filtration_value){ + virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, + bool default_filtration_value) override { return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, exact_version_, default_filtration_value); } @@ -89,12 +89,12 @@ class Inexact_Alphacomplex_dD : public Abstract_alpha_complex { alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal<Point>)) { } - std::vector<double> get_point(int vh) { + virtual std::vector<double> get_point(int vh) override { Point const& point = alpha_complex_.get_point(vh); return pt_cgal_to_cython(point); } - bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, - bool default_filtration_value){ + virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, + bool default_filtration_value) override { return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, exact_version_, default_filtration_value); } @@ -117,13 +117,13 @@ class Alphacomplex_3D : public Abstract_alpha_complex { : alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal_3)) { } - std::vector<double> get_point(int vh) { + virtual std::vector<double> get_point(int vh) override { Point const& point = alpha_complex_.get_point(vh); return pt_cgal_to_cython(point); } - bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, - bool default_filtration_value){ + virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, + bool default_filtration_value) override { return alpha_complex_.create_complex(*simplex_tree, max_alpha_square); } |