From b9fef938c7b833679f98e9618df72a2c74abeaa3 Mon Sep 17 00:00:00 2001 From: Marc Glisse Date: Fri, 18 Feb 2022 19:32:10 +0100 Subject: doc details --- src/Collapse/doc/intro_edge_collapse.h | 2 +- src/Collapse/include/gudhi/Flag_complex_edge_collapser.h | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'src/Collapse') diff --git a/src/Collapse/doc/intro_edge_collapse.h b/src/Collapse/doc/intro_edge_collapse.h index fde39707..aed02bbb 100644 --- a/src/Collapse/doc/intro_edge_collapse.h +++ b/src/Collapse/doc/intro_edge_collapse.h @@ -17,7 +17,7 @@ namespace collapse { /** \defgroup edge_collapse Edge collapse * - * \author Siddharth Pritam + * \author Siddharth Pritam and Marc Glisse * * @{ * diff --git a/src/Collapse/include/gudhi/Flag_complex_edge_collapser.h b/src/Collapse/include/gudhi/Flag_complex_edge_collapser.h index 3f7c95ac..5fb8b588 100644 --- a/src/Collapse/include/gudhi/Flag_complex_edge_collapser.h +++ b/src/Collapse/include/gudhi/Flag_complex_edge_collapser.h @@ -280,7 +280,7 @@ end_move: }; /** \brief Implicitly constructs a flag complex from edges as an input, collapses edges while preserving the persistent - * homology and returns the remaining edges as a range. + * homology and returns the remaining edges as a range. The filtration value of vertices is irrelevant to this function. * * \param[in] edges Range of Filtered edges. There is no need for the range to be sorted, as it will be done internally. * @@ -292,6 +292,10 @@ end_move: * * \ingroup edge_collapse * + * \note + * Advanced: Defining the macro GUDHI_COLLAPSE_USE_DENSE_ARRAY tells gudhi to allocate a square table of size the + * maximum vertex index. This usually speeds up the computation for dense graphs. However, for sparse graphs, the memory + * use may be problematic and initializing this large table may be slow. */ template auto flag_complex_collapse_edges(FilteredEdgeRange&& edges, Delay&&delay) { // Would it help to label the points according to some spatial sorting? -- cgit v1.2.3