From 4ebdf2b588017f2ac4a07753c2b1c2a6a569e576 Mon Sep 17 00:00:00 2001 From: ROUVREAU Vincent Date: Mon, 21 Sep 2020 16:19:42 +0200 Subject: struct Function should be abstract and virtual functions signatures --- .../include/gudhi/Functions/Function_chair_in_R3.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/Coxeter_triangulation/include/gudhi/Functions/Function_chair_in_R3.h') diff --git a/src/Coxeter_triangulation/include/gudhi/Functions/Function_chair_in_R3.h b/src/Coxeter_triangulation/include/gudhi/Functions/Function_chair_in_R3.h index 2a76e631..26b62731 100644 --- a/src/Coxeter_triangulation/include/gudhi/Functions/Function_chair_in_R3.h +++ b/src/Coxeter_triangulation/include/gudhi/Functions/Function_chair_in_R3.h @@ -35,7 +35,7 @@ struct Function_chair_in_R3 : public Function { * \brief Value of the function at a specified point. * @param[in] p The input point. The dimension needs to coincide with the ambient dimension. */ - Eigen::VectorXd operator()(const Eigen::VectorXd& p) const { + virtual Eigen::VectorXd operator()(const Eigen::VectorXd& p) const override { double x = p(0)-off_[0], y = p(1)-off_[1], z = p(2)-off_[2]; Eigen::VectorXd result(cod_d()); result(0) = std::pow(x*x + y*y + z*z - a_*k_*k_, 2) - b_*((z-k_)*(z-k_) - 2*x*x)*((z+k_)*(z+k_) - 2*y*y); @@ -43,13 +43,13 @@ struct Function_chair_in_R3 : public Function { } /** \brief Returns the domain (ambient) dimension. */ - std::size_t amb_d() const {return 3;} + virtual std::size_t amb_d() const override {return 3;} /** \brief Returns the codomain dimension. */ - std::size_t cod_d() const {return 1;} + virtual std::size_t cod_d() const override {return 1;} /** \brief Returns a point on the surface. */ - Eigen::VectorXd seed() const { + virtual Eigen::VectorXd seed() const override { double t1 = a_-b_; double discr = t1*t1 - (1.0 - b_)*(a_*a_ - b_); double z0 = k_*std::sqrt((t1+std::sqrt(discr))/(1-b_)); -- cgit v1.2.3