From e6676dce1b5faa2c61707968e1e0588e5c47edbf Mon Sep 17 00:00:00 2001
From: ROUVREAU Vincent <vincent.rouvreau@inria.fr>
Date: Thu, 27 Jun 2019 17:47:58 +0200
Subject: code review: test if first!=last before dereferencing first

---
 src/Simplex_tree/include/gudhi/Simplex_tree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/Simplex_tree/include/gudhi')

diff --git a/src/Simplex_tree/include/gudhi/Simplex_tree.h b/src/Simplex_tree/include/gudhi/Simplex_tree.h
index 80d8dfb9..519703e6 100644
--- a/src/Simplex_tree/include/gudhi/Simplex_tree.h
+++ b/src/Simplex_tree/include/gudhi/Simplex_tree.h
@@ -821,7 +821,7 @@ class Simplex_tree {
       }
     }
     // Next iteration to avoid consecutive equal values
-    while ((vertex_one == *first) && (first < last)) {
+    while ((first < last) && (vertex_one == *first)) {
       ++first;
     }
     // End of insertion
-- 
cgit v1.2.3