From 4be27acc9ad9d1c1d8f67c0c3839022b910b8b75 Mon Sep 17 00:00:00 2001 From: vrouvrea Date: Fri, 25 Aug 2017 08:13:28 +0000 Subject: Code review : use boost::adaptors::reverse(intersection) instead of std::reverse Doc review : siblings make no sense to a user git-svn-id: svn+ssh://scm.gforge.inria.fr/svnroot/gudhi/branches/graph_expansion_with_blocker_oracle@2630 636b058d-ea47-450e-bf9e-a15bfbe3eedb Former-commit-id: 0c9f2b3159294687241ad994e0c7fa7098d31285 --- src/Simplex_tree/include/gudhi/Simplex_tree.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/Simplex_tree/include') diff --git a/src/Simplex_tree/include/gudhi/Simplex_tree.h b/src/Simplex_tree/include/gudhi/Simplex_tree.h index b7ec2c1c..7815b95d 100644 --- a/src/Simplex_tree/include/gudhi/Simplex_tree.h +++ b/src/Simplex_tree/include/gudhi/Simplex_tree.h @@ -1138,10 +1138,10 @@ class Simplex_tree { } if (intersection.size() != 0) { // Reverse the order to insert - std::reverse(std::begin(intersection), std::end(intersection)); + //std::reverse(std::begin(intersection), std::end(intersection)); Siblings * new_sib = new Siblings(siblings, // oncles simplex->first, // parent - intersection); // boost::container::ordered_unique_range_t + boost::adaptors::reverse(intersection)); // boost::container::ordered_unique_range_t // intersection must be cleared before the function to be called recursively intersection.clear(); @@ -1297,7 +1297,7 @@ class Simplex_tree { public: /** \brief Remove a maximal simplex. * @param[in] sh Simplex handle on the maximal simplex to remove. - * @return true if siblings was deleted, false otherwise. + * @return true if simplex was deleted, false otherwise. * \pre Please check the simplex has no coface before removing it. * \exception std::invalid_argument In debug mode, if sh has children. * \post Be aware that removing is shifting data in a flat_map (initialize_filtration to be done). -- cgit v1.2.3