From a81c5adcf4426338ff80cfb2f1973f113a17b16d Mon Sep 17 00:00:00 2001 From: ROUVREAU Vincent Date: Thu, 4 Jun 2020 22:13:46 +0200 Subject: code review: better use a for loop --- src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src') diff --git a/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h b/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h index 75df52bf..67399044 100644 --- a/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h +++ b/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h @@ -339,7 +339,6 @@ class Flag_complex_sparse_matrix { */ template void filtered_edge_collapse(FilteredEdgeOutput filtered_edge_output) { - Row_index endIdx = 0; // Sort edges auto sort_by_filtration = [](const Filtered_edge& edge_a, const Filtered_edge& edge_b) -> bool { @@ -352,7 +351,7 @@ class Flag_complex_sparse_matrix { std::sort(f_edge_vector_.begin(), f_edge_vector_.end(), sort_by_filtration); #endif - while (endIdx < f_edge_vector_.size()) { + for (Row_index endIdx = 0; endIdx < f_edge_vector_.size(); endIdx++) { Filtered_edge fec = f_edge_vector_[endIdx]; Edge edge = std::get<0>(fec); Vertex_handle u = std::get<0>(edge); @@ -371,7 +370,6 @@ class Flag_complex_sparse_matrix { if (endIdx > 1) set_edge_critical(endIdx, filt, filtered_edge_output); } - endIdx++; } } -- cgit v1.2.3