summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorROUVREAU Vincent <vincent.rouvreau@inria.fr>2020-10-05 10:33:23 +0200
committerROUVREAU Vincent <vincent.rouvreau@inria.fr>2020-10-05 10:33:23 +0200
commit74143b372d3d93fc2139974fa85906047acee8a7 (patch)
tree332398c2e3d5f1bf0f9fae384aee9ca5a0bc87db
parent91ec6130f63a8a117ca9dc0bfff0cd663a1e35e7 (diff)
code review: push_back versus emplace_back
-rw-r--r--src/Alpha_complex/include/gudhi/Alpha_complex.h6
-rw-r--r--src/Alpha_complex/utilities/alpha_complex_persistence.cpp2
2 files changed, 4 insertions, 4 deletions
diff --git a/src/Alpha_complex/include/gudhi/Alpha_complex.h b/src/Alpha_complex/include/gudhi/Alpha_complex.h
index 4f8e3d54..a692dbc6 100644
--- a/src/Alpha_complex/include/gudhi/Alpha_complex.h
+++ b/src/Alpha_complex/include/gudhi/Alpha_complex.h
@@ -310,7 +310,7 @@ class Alpha_complex {
thread_local std::vector<Point_d> v;
v.clear();
for (auto vertex : cplx.simplex_vertex_range(s))
- v.emplace_back(get_point_(vertex));
+ v.push_back(get_point_(vertex));
cache_.emplace_back(kernel_.get_sphere(v.cbegin(), v.cend()));
}
return cache_[k];
@@ -326,7 +326,7 @@ class Alpha_complex {
thread_local std::vector<Point_d> v;
v.clear();
for (auto vertex : cplx.simplex_vertex_range(s))
- v.emplace_back(get_point_(vertex));
+ v.push_back(get_point_(vertex));
return kernel_.get_squared_radius(v.cbegin(), v.cend());
}
@@ -394,7 +394,7 @@ class Alpha_complex {
std::clog << " " << (*vit)->data();
#endif // DEBUG_TRACES
// Vector of vertex construction for simplex_tree structure
- vertexVector.emplace_back((*vit)->data());
+ vertexVector.push_back((*vit)->data());
}
}
#ifdef DEBUG_TRACES
diff --git a/src/Alpha_complex/utilities/alpha_complex_persistence.cpp b/src/Alpha_complex/utilities/alpha_complex_persistence.cpp
index 3ce7b440..e86b34e2 100644
--- a/src/Alpha_complex/utilities/alpha_complex_persistence.cpp
+++ b/src/Alpha_complex/utilities/alpha_complex_persistence.cpp
@@ -50,7 +50,7 @@ std::vector<double> read_weight_file(const std::string &weight_file) {
double weight = 0.0;
// Attempt read the weight in a double format, return false if it fails
while (weights_ifstr >> weight) {
- weights.emplace_back(weight);
+ weights.push_back(weight);
}
} else {
std::cerr << "Unable to read weights file " << weight_file << std::endl;