From 9ae3c860517e5d8248e13df0d0e8a05fcf765262 Mon Sep 17 00:00:00 2001 From: ROUVREAU Vincent Date: Thu, 4 Jun 2020 17:19:28 +0200 Subject: code review: no need to loop backward --- src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/Collapse') diff --git a/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h b/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h index b53c8ab7..3afacd0e 100644 --- a/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h +++ b/src/Collapse/include/gudhi/Flag_complex_sparse_matrix.h @@ -196,8 +196,8 @@ class Flag_complex_sparse_matrix { critical_edge_indicator_[idx] = true; filtered_edge_output({u, v}, filt); std::set inner_effected_indcs = three_clique_indices(idx); - for (auto inr_idx = inner_effected_indcs.rbegin(); inr_idx != inner_effected_indcs.rend(); inr_idx++) { - if (*inr_idx < idx) effected_indices.emplace(*inr_idx); + for (auto inr_idx : inner_effected_indcs) { + effected_indices.emplace(inr_idx); } #ifdef DEBUG_TRACES std::cout << "The following edge is critical with filt value: {" << u << "," << v << "}; " -- cgit v1.2.3