From 251d5726f17275b0af8333440b21476751925e1b Mon Sep 17 00:00:00 2001 From: vrouvrea Date: Thu, 15 Dec 2016 22:53:16 +0000 Subject: Fix after code review git-svn-id: svn+ssh://scm.gforge.inria.fr/svnroot/gudhi/trunk@1889 636b058d-ea47-450e-bf9e-a15bfbe3eedb Former-commit-id: 9ec3dcd290042159c313a83be3a3e8fb7bafa6e8 --- .../include/gudhi/Persistent_cohomology.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/Persistent_cohomology/include') diff --git a/src/Persistent_cohomology/include/gudhi/Persistent_cohomology.h b/src/Persistent_cohomology/include/gudhi/Persistent_cohomology.h index d3a8acc0..c3a1535a 100644 --- a/src/Persistent_cohomology/include/gudhi/Persistent_cohomology.h +++ b/src/Persistent_cohomology/include/gudhi/Persistent_cohomology.h @@ -690,17 +690,17 @@ class Persistent_cohomology { return persistent_pairs_; } - /** @brief Returns persistence pairs for a given dimension. + /** @brief Returns persistence intervals for a given dimension. * @param[in] dimension Dimension to get the birth and death pairs from. * @return A vector of persistence intervals (birth and death) on a fixed dimension. */ std::vector< std::pair< Filtration_value , Filtration_value > > - pairs_in_dimension( unsigned dimension ) { + intervals_in_dimension(int dimension) { std::vector< std::pair< Filtration_value , Filtration_value > > result; - for (auto pair : persistent_pairs_) { + // auto && pair, to avoid unnecessary copying + for (auto && pair : persistent_pairs_) { if (cpx_->dimension( get<0>(pair)) == dimension ) { - result.push_back(std::pair(cpx_->filtration(get<0>(pair)), - cpx_->filtration(get<1>(pair)))); + result.emplace_back(cpx_->filtration(get<0>(pair)), cpx_->filtration(get<1>(pair))); } } return result; -- cgit v1.2.3