summaryrefslogtreecommitdiff
path: root/src/Simplex_tree/include/gudhi/Simplex_tree.h
diff options
context:
space:
mode:
authorMarc Glisse <marc.glisse@inria.fr>2020-03-17 13:28:35 +0100
committerMarc Glisse <marc.glisse@inria.fr>2020-03-17 13:28:35 +0100
commit47e72c7250bff568735df829a40bcbea0a48f7c2 (patch)
treebff219c038235a61c79e1a21105e6ec2c8cecd63 /src/Simplex_tree/include/gudhi/Simplex_tree.h
parent8bd39f74f69e8fcb662873e0e045c953b814f28f (diff)
Remove code that was commented out.
Diffstat (limited to 'src/Simplex_tree/include/gudhi/Simplex_tree.h')
-rw-r--r--src/Simplex_tree/include/gudhi/Simplex_tree.h12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/Simplex_tree/include/gudhi/Simplex_tree.h b/src/Simplex_tree/include/gudhi/Simplex_tree.h
index ad592a92..af711075 100644
--- a/src/Simplex_tree/include/gudhi/Simplex_tree.h
+++ b/src/Simplex_tree/include/gudhi/Simplex_tree.h
@@ -1494,16 +1494,8 @@ class Simplex_tree {
*
* \pre `sh` must have dimension at least 1. */
Simplex_handle edge_with_same_filtration(Simplex_handle sh) {
-#if 0
- // FIXME: Only do this if dim >= 2, since we don't want to return a vertex...
- // Test if we are lucky and the parent has the same filtration value.
- Siblings* sib = self_siblings(sh);
- Vertex_handle v_par = sib->parent();
- sib = sib->oncles();
- Simplex_handle par = sib->find(v_par);
- if(filtration_(par) == filt) return edge_with_same_filtration(par);
-#endif
- auto&& vertices = simplex_vertex_range(sh);
+ // See issue #251 for potential speed improvements.
+ auto&& vertices = simplex_vertex_range(sh); // vertices in decreasing order
auto end = std::end(vertices);
auto vi = std::begin(vertices);
GUDHI_CHECK(vi != end, "empty simplex");