summaryrefslogtreecommitdiff
path: root/src/Simplex_tree/include/gudhi/Simplex_tree.h
diff options
context:
space:
mode:
authorMathieuCarriere <mathieu.carriere3@gmail.com>2020-03-17 12:14:49 -0400
committerMathieuCarriere <mathieu.carriere3@gmail.com>2020-03-17 12:14:49 -0400
commit58d923b13afb9b18a2d5b028c6575baee691d182 (patch)
tree2242fb61d711f6c7abcc20ea355a38eb3a36d9e6 /src/Simplex_tree/include/gudhi/Simplex_tree.h
parenta52e84fdcdbf66f3542416499c26245d0435a8fb (diff)
update python doc
Diffstat (limited to 'src/Simplex_tree/include/gudhi/Simplex_tree.h')
-rw-r--r--src/Simplex_tree/include/gudhi/Simplex_tree.h8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/Simplex_tree/include/gudhi/Simplex_tree.h b/src/Simplex_tree/include/gudhi/Simplex_tree.h
index 02f2c7e9..f661f687 100644
--- a/src/Simplex_tree/include/gudhi/Simplex_tree.h
+++ b/src/Simplex_tree/include/gudhi/Simplex_tree.h
@@ -1478,8 +1478,8 @@ class Simplex_tree {
* \post The coordinates of the persistence diagram points might be a little different than the
* original filtration values due to the internal transformation (scaling to [-2,-1]) that is
* performed on these values during the computation of extended persistence.
- * @param[in] dgm Persistence diagram obtained after calling this->extend_filtration
- * and this->get_persistence.
+ * @param[in] dgm Persistence diagram obtained after calling this->extend_filtration,
+ * this->initialize_filtration, and this->compute_persistent_cohomology.
* @return A vector of four persistence diagrams. The first one is Ordinary, the
* second one is Relative, the third one is Extended+ and the fourth one is Extended-.
* See section 2.2 in https://link.springer.com/article/10.1007/s10208-017-9370-z for a description of these subtypes.
@@ -1538,14 +1538,14 @@ class Simplex_tree {
int maxvert = std::numeric_limits<int>::min();
this->minval_ = std::numeric_limits<double>::max();
this->maxval_ = std::numeric_limits<double>::min();
- for (auto sh : this->skeleton_simplex_range(0)) {
+ for (auto sh = root_.members().begin(); sh != root_.members().end(); ++sh){
double f = this->filtration(sh);
this->minval_ = std::min(this->minval_, f);
this->maxval_ = std::max(this->maxval_, f);
maxvert = std::max(*this->simplex_vertex_range(sh).begin(), maxvert);
}
- assert (maxvert < std::numeric_limits<int>::max());
+ GUDHI_CHECK(maxvert < std::numeric_limits<int>::max(), std::invalid_argument("Simplex_tree contains a vertex with the largest Vertex_handle"));
maxvert += 1;
Simplex_tree* st_copy = new Simplex_tree(*this);