Warning fixes

git-svn-id: svn+ssh://scm.gforge.inria.fr/svnroot/gudhi/trunk@1905 636b058d-ea47-450e-bf9e-a15bfbe3eedb

Former-commit-id: 7b7222ebe65fd01fde30f8ba527ebaee633fc87e

3 files changed, 56 insertions, 6 deletions

diff --git a/src/Subsampling/include/gudhi/choose_n_farthest_points.h b/src/Subsampling/include/gudhi/choose_n_farthest_points.h
index ea387bf9..5e908090 100644
--- a/src/Subsampling/include/gudhi/choose_n_farthest_points.h
+++ b/src/Subsampling/include/gudhi/choose_n_farthest_points.h
@@ -145,7 +145,8 @@ void choose_n_farthest_points(Kernel const& k,
   std::random_device rd;
   std::mt19937 gen(rd());
   std::uniform_int_distribution<> dis(0, (input_pts.size() - 1));
-  int starting_point = dis(gen);
+  std::size_t starting_point = dis(gen);
+
   choose_n_farthest_points(k, input_pts, final_size, starting_point, output_it);
 }
 
diff --git a/src/Subsampling/include/gudhi/pick_n_random_points.h b/src/Subsampling/include/gudhi/pick_n_random_points.h
index e89b2b2d..f0e3f1f1 100644
--- a/src/Subsampling/include/gudhi/pick_n_random_points.h
+++ b/src/Subsampling/include/gudhi/pick_n_random_points.h
@@ -57,7 +57,9 @@ void pick_n_random_points(Point_container const &points,
 #endif
 
   std::size_t nbP = boost::size(points);
-  assert(nbP >= final_size);
+  if (final_size > nbP)
+      final_size = nbP;
+
   std::vector<int> landmarks(nbP);
   std::iota(landmarks.begin(), landmarks.end(), 0);
 
diff --git a/src/Subsampling/test/test_choose_n_farthest_points.cpp b/src/Subsampling/test/test_choose_n_farthest_points.cpp
index d064899a..0bc0dff4 100644
--- a/src/Subsampling/test/test_choose_n_farthest_points.cpp
+++ b/src/Subsampling/test/test_choose_n_farthest_points.cpp
@@ -39,18 +39,65 @@ typedef CGAL::Epick_d<CGAL::Dynamic_dimension_tag> K;
 typedef typename K::FT FT;
 typedef typename K::Point_d Point_d;
 
-BOOST_AUTO_TEST_CASE(test_choose_farthest_point) {
+typedef boost::mpl::list<CGAL::Epick_d<CGAL::Dynamic_dimension_tag>, CGAL::Epick_d<CGAL::Dimension_tag<4>>> list_of_tested_kernels;
+
+BOOST_AUTO_TEST_CASE_TEMPLATE(test_choose_farthest_point, Kernel, list_of_tested_kernels) {
+  typedef typename Kernel::FT FT;
+  typedef typename Kernel::Point_d Point_d;
   std::vector< Point_d > points, landmarks;
   // Add grid points (625 points)
   for (FT i = 0; i < 5; i += 1.0)
     for (FT j = 0; j < 5; j += 1.0)
       for (FT k = 0; k < 5; k += 1.0)
-        for (FT l = 0; l < 5; l += 1.0)
-          points.push_back(Point_d(std::vector<FT>({i, j, k, l})));
+        for (FT l = 0; l < 5; l += 1.0) {
+          std::vector<FT> point({i, j, k, l});
+          points.push_back(Point_d(point.begin(), point.end()));
+        }
 
   landmarks.clear();
-  K k;
+  Kernel k;
   Gudhi::subsampling::choose_n_farthest_points(k, points, 100, std::back_inserter(landmarks));
 
   BOOST_CHECK(landmarks.size() == 100);
+  for (auto landmark : landmarks)
+  {
+    // Check all landmarks are in points
+    BOOST_CHECK(std::find (points.begin(), points.end(), landmark) != points.end());
+  }
+}
+
+BOOST_AUTO_TEST_CASE_TEMPLATE(test_choose_farthest_point_limits, Kernel, list_of_tested_kernels) {
+  typedef typename Kernel::FT FT;
+  typedef typename Kernel::Point_d Point_d;
+  std::vector< Point_d > points, landmarks;
+  landmarks.clear();
+  Kernel k;
+  // Choose -1 farthest points in an empty point cloud
+  Gudhi::subsampling::choose_n_farthest_points(k, points, -1, std::back_inserter(landmarks));
+  BOOST_CHECK(landmarks.size() == 0);
+  landmarks.clear();
+  // Choose 0 farthest points in an empty point cloud
+  Gudhi::subsampling::choose_n_farthest_points(k, points, 0, std::back_inserter(landmarks));
+  BOOST_CHECK(landmarks.size() == 0);
+  landmarks.clear();
+  // Choose 1 farthest points in an empty point cloud
+  Gudhi::subsampling::choose_n_farthest_points(k, points, 1, std::back_inserter(landmarks));
+  BOOST_CHECK(landmarks.size() == 0);
+  landmarks.clear();
+
+  std::vector<FT> point({0.0, 0.0, 0.0, 0.0});
+  points.push_back(Point_d(point.begin(), point.end()));
+  // Choose -1 farthest points in an empty point cloud
+  Gudhi::subsampling::choose_n_farthest_points(k, points, -1, std::back_inserter(landmarks));
+  BOOST_CHECK(landmarks.size() == 1);
+  landmarks.clear();
+  // Choose 0 farthest points in a one point cloud
+  Gudhi::subsampling::choose_n_farthest_points(k, points, 0, std::back_inserter(landmarks));
+  BOOST_CHECK(landmarks.size() == 0);
+  landmarks.clear();
+  // Choose 1 farthest points in a one point cloud
+  Gudhi::subsampling::choose_n_farthest_points(k, points, 1, std::back_inserter(landmarks));
+  BOOST_CHECK(landmarks.size() == 1);
+  landmarks.clear();
+
 }