summaryrefslogtreecommitdiff
path: root/src/python/include/Simplex_tree_interface.h
diff options
context:
space:
mode:
authorROUVREAU Vincent <vincent.rouvreau@inria.fr>2020-02-26 11:11:32 +0100
committerROUVREAU Vincent <vincent.rouvreau@inria.fr>2020-02-26 11:11:32 +0100
commitf85742957276cbd15a2724c86cbc7a8279d62ef9 (patch)
tree2bbec2f662725102f063c50c3b24053c8d5662a3 /src/python/include/Simplex_tree_interface.h
parent571cf3f3087f84a251e3029ffe357cc4434528d1 (diff)
Code review: add some comments about range.begin() and range.end()
Diffstat (limited to 'src/python/include/Simplex_tree_interface.h')
-rw-r--r--src/python/include/Simplex_tree_interface.h4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/python/include/Simplex_tree_interface.h b/src/python/include/Simplex_tree_interface.h
index 55d5af97..66ce5afd 100644
--- a/src/python/include/Simplex_tree_interface.h
+++ b/src/python/include/Simplex_tree_interface.h
@@ -124,18 +124,22 @@ class Simplex_tree_interface : public Simplex_tree<SimplexTreeOptions> {
// Iterator over the simplex tree
typename std::vector<Simplex_handle>::const_iterator get_filtration_iterator_begin() {
// Base::initialize_filtration(); already performed in filtration_simplex_range
+ // this specific case works because the range is just a pair of iterators - won't work if range was a vector
return Base::filtration_simplex_range().begin();
}
typename std::vector<Simplex_handle>::const_iterator get_filtration_iterator_end() {
+ // this specific case works because the range is just a pair of iterators - won't work if range was a vector
return Base::filtration_simplex_range().end();
}
Skeleton_simplex_iterator get_skeleton_iterator_begin(int dimension) {
+ // this specific case works because the range is just a pair of iterators - won't work if range was a vector
return Base::skeleton_simplex_range(dimension).begin();
}
Skeleton_simplex_iterator get_skeleton_iterator_end(int dimension) {
+ // this specific case works because the range is just a pair of iterators - won't work if range was a vector
return Base::skeleton_simplex_range(dimension).end();
}
};