summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/python/doc/wasserstein_distance_user.rst14
-rw-r--r--src/python/gudhi/hera.cc8
2 files changed, 18 insertions, 4 deletions
diff --git a/src/python/doc/wasserstein_distance_user.rst b/src/python/doc/wasserstein_distance_user.rst
index a049cfb5..13f6f1af 100644
--- a/src/python/doc/wasserstein_distance_user.rst
+++ b/src/python/doc/wasserstein_distance_user.rst
@@ -9,12 +9,20 @@ Definition
.. include:: wasserstein_distance_sum.inc
-This implementation is based on ideas from "Large Scale Computation of Means and Cluster for Persistence Diagrams via Optimal Transport".
+Functions
+---------
+This implementation is based on ideas from "Large Scale Computation of Means
+and Cluster for Persistence Diagrams via Optimal Transport".
-Function
---------
.. autofunction:: gudhi.wasserstein.wasserstein_distance
+This other implementation comes from `Hera
+<https://bitbucket.org/grey_narn/hera/src/master/>`_ and is based on `"Geometry
+Helps to Compare Persistence Diagrams."
+<http://dx.doi.org/10.1137/1.9781611974317.9>`_ by Michael Kerber, Dmitriy
+Morozov, and Arnur Nigmetov, at ALENEX 2016.
+
+.. autofunction:: gudhi.hera.wasserstein_distance
Basic example
-------------
diff --git a/src/python/gudhi/hera.cc b/src/python/gudhi/hera.cc
index 7cef9425..04f5990f 100644
--- a/src/python/gudhi/hera.cc
+++ b/src/python/gudhi/hera.cc
@@ -42,7 +42,13 @@ double wasserstein_distance(
}
PYBIND11_MODULE(hera, m) {
- m.def("wasserstein_distance", &wasserstein_distance, R"pbdoc(
+ m.def("wasserstein_distance", &wasserstein_distance,
+ py::arg("X"), py::arg("Y"),
+ R"pbdoc(
Compute the Wasserstein distance between two diagrams
+
+ Parameters:
+ X (n x 2 numpy array): First diagram
+ Y (n x 2 numpy array): Second diagram
)pbdoc");
}