From 72a56067c5a6f105ff60996e7257063505030e73 Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Wed, 19 Jan 2022 09:50:13 +0100 Subject: Code review: exact_version was useless in Inexact_alpha_complex_dD --- src/python/include/Alpha_complex_factory.h | 14 +++++--------- src/python/include/Alpha_complex_interface.h | 4 ++-- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/python/include/Alpha_complex_factory.h b/src/python/include/Alpha_complex_factory.h index 8f820fc9..14ec1f86 100644 --- a/src/python/include/Alpha_complex_factory.h +++ b/src/python/include/Alpha_complex_factory.h @@ -118,15 +118,12 @@ class Inexact_alpha_complex_dD final : public Abstract_alpha_complex { typename Kernel::Point_d>; public: - Inexact_alpha_complex_dD(const std::vector>& points, bool exact_version) - : exact_version_(exact_version), - alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal)) { + Inexact_alpha_complex_dD(const std::vector>& points) + : alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal)) { } - Inexact_alpha_complex_dD(const std::vector>& points, - const std::vector& weights, bool exact_version) - : exact_version_(exact_version), - alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal), weights) { + Inexact_alpha_complex_dD(const std::vector>& points, const std::vector& weights) + : alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal), weights) { } virtual std::vector get_point(int vh) override { @@ -135,11 +132,10 @@ class Inexact_alpha_complex_dD final : public Abstract_alpha_complex { } virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, bool default_filtration_value) override { - return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, exact_version_, default_filtration_value); + return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, false, default_filtration_value); } private: - bool exact_version_; Alpha_complex alpha_complex_; }; diff --git a/src/python/include/Alpha_complex_interface.h b/src/python/include/Alpha_complex_interface.h index ed243f19..188036ed 100644 --- a/src/python/include/Alpha_complex_interface.h +++ b/src/python/include/Alpha_complex_interface.h @@ -34,9 +34,9 @@ class Alpha_complex_interface { const bool weighted = (weights.size() > 0); if (fast_version) { if (weighted) { - alpha_ptr_ = std::make_unique>(points, weights, exact_version); + alpha_ptr_ = std::make_unique>(points, weights); } else { - alpha_ptr_ = std::make_unique>(points, exact_version); + alpha_ptr_ = std::make_unique>(points); } } else { if (weighted) { -- cgit v1.2.3