From 96f1dc0310d146e2bc368624683f46f1ca9a5116 Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Wed, 14 Sep 2022 10:29:22 +0200 Subject: c++17 is the new standard and MSVC 17 also --- src/cmake/modules/GUDHI_compilation_flags.cmake | 2 +- src/common/doc/installation.h | 4 ++-- src/python/doc/installation.rst | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cmake/modules/GUDHI_compilation_flags.cmake b/src/cmake/modules/GUDHI_compilation_flags.cmake index 567fbc40..e2d3d872 100644 --- a/src/cmake/modules/GUDHI_compilation_flags.cmake +++ b/src/cmake/modules/GUDHI_compilation_flags.cmake @@ -11,7 +11,7 @@ macro(add_cxx_compiler_flag _flag) endif() endmacro() -set (CMAKE_CXX_STANDARD 14) +set (CMAKE_CXX_STANDARD 17) enable_testing() diff --git a/src/common/doc/installation.h b/src/common/doc/installation.h index 28526498..a05ac588 100644 --- a/src/common/doc/installation.h +++ b/src/common/doc/installation.h @@ -5,9 +5,9 @@ * Examples of GUDHI headers inclusion can be found in \ref utilities. * * \section compiling Compiling - * The library uses c++14 and requires Boost ≥ 1.66.0 + * The library uses c++17 and requires Boost ≥ 1.66.0 * and CMake ≥ 3.5. - * It is a multi-platform library and compiles on Linux, Mac OSX and Visual Studio 2015. + * It is a multi-platform library and compiles on Linux, Mac OSX and Visual Studio 2017. * * \subsection utilities Utilities and examples * To build the utilities, run the following commands in a terminal: diff --git a/src/python/doc/installation.rst b/src/python/doc/installation.rst index 4eefd415..b704f778 100644 --- a/src/python/doc/installation.rst +++ b/src/python/doc/installation.rst @@ -39,7 +39,7 @@ If you are instead using a git checkout, beware that the paths are a bit different, and in particular the `python/` subdirectory is actually `src/python/` there. -The library uses c++14 and requires `Boost `_ :math:`\geq` 1.66.0, +The library uses c++17 and requires `Boost `_ :math:`\geq` 1.66.0, `CMake `_ :math:`\geq` 3.5 to generate makefiles, Python :math:`\geq` 3.5, `NumPy `_ :math:`\geq` 1.15.0, `Cython `_ :math:`\geq` 0.27 and `pybind11 `_ to compile the GUDHI Python module. -- cgit v1.2.3 From eee4180428d97ffef99e86123134835682181594 Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Wed, 14 Sep 2022 10:30:19 +0200 Subject: std::ofstream::streampos is deprecated with c++17 --- src/Tangential_complex/benchmark/XML_exporter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tangential_complex/benchmark/XML_exporter.h b/src/Tangential_complex/benchmark/XML_exporter.h index 16b62eb6..38fe049f 100644 --- a/src/Tangential_complex/benchmark/XML_exporter.h +++ b/src/Tangential_complex/benchmark/XML_exporter.h @@ -157,7 +157,7 @@ class Streaming_XML_exporter { m_xml_fstream << " " << std::endl; // Save current pointer position - std::ofstream::streampos pos = m_xml_fstream.tellp(); + auto pos = m_xml_fstream.tellp(); // Close the XML file (temporarily) so that the XML file is always correct m_xml_fstream << "" << std::endl; // Restore the pointer position so that the next "add_element" will overwrite -- cgit v1.2.3 From fd66e103bd7f6fba20f0eb915294dacb15807747 Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Wed, 14 Sep 2022 10:34:37 +0200 Subject: Update release note accordingly to c++17 new standard --- .github/next_release.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/next_release.md b/.github/next_release.md index 64bda353..81599b2c 100644 --- a/.github/next_release.md +++ b/.github/next_release.md @@ -9,8 +9,8 @@ Below is a list of changes made since GUDHI 3.6.0: - [Module](link) - ... -- [Module](link) - - ... +- Installation + - c++17 is the new minimal standard to compile the library. This implies Visual Studio minimal version is now 2017. - Miscellaneous - The [list of bugs that were solved since GUDHI-3.6.0](https://github.com/GUDHI/gudhi-devel/issues?q=label%3A3.7.0+is%3Aclosed) is available on GitHub. -- cgit v1.2.3