From c3a4fc7bdcc69a5d56761c67a77c7e5b6ff6d1ee Mon Sep 17 00:00:00 2001 From: ROUVREAU Vincent Date: Mon, 3 Aug 2020 08:32:48 +0200 Subject: code review: simplify edge parsing --- src/python/include/Simplex_tree_interface.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src/python/include/Simplex_tree_interface.h') diff --git a/src/python/include/Simplex_tree_interface.h b/src/python/include/Simplex_tree_interface.h index f786ad6e..e288a8cf 100644 --- a/src/python/include/Simplex_tree_interface.h +++ b/src/python/include/Simplex_tree_interface.h @@ -164,11 +164,12 @@ class Simplex_tree_interface : public Simplex_tree { using Filtered_edge = std::tuple; std::vector edges; for (Simplex_handle sh : Base::skeleton_simplex_range(1)) { - typename Base::Simplex_vertex_range rg = Base::simplex_vertex_range(sh); - auto rg_begin = rg.begin(); - // We take only edges into account - if (std::distance(rg_begin, rg.end()) == 2) { - edges.emplace_back(*rg_begin, *std::next(rg_begin), Base::filtration(sh)); + if (Base::dimension(sh) == 1) { + typename Base::Simplex_vertex_range rg = Base::simplex_vertex_range(sh); + auto vit = rg.begin(); + Vertex_handle v = *vit; + Vertex_handle w = *++vit; + edges.emplace_back(v, w, Base::filtration(sh)); } } -- cgit v1.2.3