From 12c0266d7defec73a6e8da3990a7fc8d482cbde5 Mon Sep 17 00:00:00 2001
From: ROUVREAU Vincent <vincent.rouvreau@inria.fr>
Date: Fri, 31 Jul 2020 15:23:40 +0200
Subject: code review: nogil and use ptr as suggested

---
 src/python/gudhi/simplex_tree.pyx | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

(limited to 'src')

diff --git a/src/python/gudhi/simplex_tree.pyx b/src/python/gudhi/simplex_tree.pyx
index 236435a7..9eee5e14 100644
--- a/src/python/gudhi/simplex_tree.pyx
+++ b/src/python/gudhi/simplex_tree.pyx
@@ -593,8 +593,10 @@ cdef class SimplexTree:
         """
         # Backup old pointer
         cdef Simplex_tree_interface_full_featured* ptr = self.get_ptr()
-        # New pointer is a new collapsed simplex tree
-        self.thisptr = <intptr_t>(self.get_ptr().collapse_edges(nb_iterations))
-        # Delete old pointer
-        if ptr != NULL:
-            del ptr
+        cdef int nb_iter = nb_iterations
+        with nogil:
+            # New pointer is a new collapsed simplex tree
+            self.thisptr = <intptr_t>(ptr.collapse_edges(nb_iter))
+            # Delete old pointer
+            if ptr != NULL:
+                del ptr
-- 
cgit v1.2.3