From 54309849264b5f5ab61e11031044d135c0bb9aa5 Mon Sep 17 00:00:00 2001 From: ROUVREAU Vincent Date: Wed, 1 Jul 2020 22:33:35 +0200 Subject: Code review: let's use override as a good practice --- src/python/include/Alpha_complex_factory.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'src') diff --git a/src/python/include/Alpha_complex_factory.h b/src/python/include/Alpha_complex_factory.h index b0e9dc93..d699ad9b 100644 --- a/src/python/include/Alpha_complex_factory.h +++ b/src/python/include/Alpha_complex_factory.h @@ -63,13 +63,13 @@ class Exact_Alphacomplex_dD : public Abstract_alpha_complex { alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal)) { } - std::vector get_point(int vh) override { + virtual std::vector get_point(int vh) override { Point const& point = alpha_complex_.get_point(vh); return pt_cgal_to_cython(point); } - bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, - bool default_filtration_value){ + virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, + bool default_filtration_value) override { return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, exact_version_, default_filtration_value); } @@ -89,12 +89,12 @@ class Inexact_Alphacomplex_dD : public Abstract_alpha_complex { alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal)) { } - std::vector get_point(int vh) { + virtual std::vector get_point(int vh) override { Point const& point = alpha_complex_.get_point(vh); return pt_cgal_to_cython(point); } - bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, - bool default_filtration_value){ + virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, + bool default_filtration_value) override { return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, exact_version_, default_filtration_value); } @@ -117,13 +117,13 @@ class Alphacomplex_3D : public Abstract_alpha_complex { : alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal_3)) { } - std::vector get_point(int vh) { + virtual std::vector get_point(int vh) override { Point const& point = alpha_complex_.get_point(vh); return pt_cgal_to_cython(point); } - bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, - bool default_filtration_value){ + virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square, + bool default_filtration_value) override { return alpha_complex_.create_complex(*simplex_tree, max_alpha_square); } -- cgit v1.2.3