diff options
author | ROUVREAU Vincent <vincent.rouvreau@inria.fr> | 2020-06-18 14:35:44 +0200 |
---|---|---|
committer | ROUVREAU Vincent <vincent.rouvreau@inria.fr> | 2020-06-18 14:35:44 +0200 |
commit | 08307b231e8fe2b044ade409b924f56b3eb7ebfe (patch) | |
tree | 91faf956aa8c7aa5d6437b08cc36e9284c0f969e /src/Collapse/example | |
parent | 0a9cadf43cf61107b6064f368f61b58db153609a (diff) |
Code review: replace push_back with emplace_back
Diffstat (limited to 'src/Collapse/example')
-rw-r--r-- | src/Collapse/example/edge_collapse_basic_example.cpp | 2 | ||||
-rw-r--r-- | src/Collapse/example/edge_collapse_conserve_persistence.cpp | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/Collapse/example/edge_collapse_basic_example.cpp b/src/Collapse/example/edge_collapse_basic_example.cpp index 17ed04a2..ac21e96f 100644 --- a/src/Collapse/example/edge_collapse_basic_example.cpp +++ b/src/Collapse/example/edge_collapse_basic_example.cpp @@ -32,7 +32,7 @@ int main() { // Retrieve collapse edges from the output iterator edge_collapser.process_edges( [&remaining_edges](std::pair<Vertex_handle, Vertex_handle> edge, Filtration_value filtration) { - remaining_edges.push_back({edge, filtration}); + remaining_edges.emplace_back(Filtered_edge(edge, filtration)); }); for (Filtered_edge filtered_edge_from_collapse : remaining_edges) { diff --git a/src/Collapse/example/edge_collapse_conserve_persistence.cpp b/src/Collapse/example/edge_collapse_conserve_persistence.cpp index b28af456..8e03fa86 100644 --- a/src/Collapse/example/edge_collapse_conserve_persistence.cpp +++ b/src/Collapse/example/edge_collapse_conserve_persistence.cpp @@ -71,9 +71,9 @@ std::vector<Persistence_pair> get_persistence_pairs(Simplex_tree& st, int ambien auto persistent_pairs = pcoh.get_persistent_pairs(); std::sort(std::begin(persistent_pairs), std::end(persistent_pairs), cmp); for (auto pair : persistent_pairs) { - ppairs.push_back({st.dimension(get<0>(pair)), - st.filtration(get<0>(pair)), - st.filtration(get<1>(pair)) }); + ppairs.emplace_back(Persistence_pair(st.dimension(get<0>(pair)), + st.filtration(get<0>(pair)), + st.filtration(get<1>(pair)) )); } return ppairs; } |