diff options
| author | Marc Glisse <marc.glisse@inria.fr> | 2022-12-10 21:05:25 +0100 |
|---|---|---|
| committer | Marc Glisse <marc.glisse@inria.fr> | 2022-12-10 21:05:25 +0100 |
| commit | 33b63b9d364bdb2d470a3eac878fe48e3a4e7da6 (patch) | |
| tree | cdf75f9aecae7d851c4c82b7c04cb6a47b63684f | |
| parent | 8226f645e01c11ccfc7919327bb281b6f805bfa4 (diff) | |
Clarify comment
| -rw-r--r-- | src/python/gudhi/bottleneck.cc | 2 | ||||
| -rw-r--r-- | src/python/gudhi/hera/bottleneck.cc | 2 | ||||
| -rw-r--r-- | src/python/gudhi/hera/wasserstein.cc | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/python/gudhi/bottleneck.cc b/src/python/gudhi/bottleneck.cc index 1cf3283c..040e6d37 100644 --- a/src/python/gudhi/bottleneck.cc +++ b/src/python/gudhi/bottleneck.cc @@ -20,7 +20,7 @@ static auto make_point(double x, double y, py::ssize_t) { return std::pair(x, y) double bottleneck(Dgm d1, Dgm d2, std::optional<double> epsilon) { double e = epsilon.value_or((std::numeric_limits<double>::min)()); - // I *think* the call to request() has to be before releasing the GIL. + // I *think* the call to request() in numpy_to_range_of_pairs has to be before releasing the GIL. auto diag1 = numpy_to_range_of_pairs(d1, make_point); auto diag2 = numpy_to_range_of_pairs(d2, make_point); diff --git a/src/python/gudhi/hera/bottleneck.cc b/src/python/gudhi/hera/bottleneck.cc index 6b919b02..9826252c 100644 --- a/src/python/gudhi/hera/bottleneck.cc +++ b/src/python/gudhi/hera/bottleneck.cc @@ -23,7 +23,7 @@ static auto make_point(double x, double y, py::ssize_t) { return std::pair(x, y) double bottleneck_distance(Dgm d1, Dgm d2, double delta) { - // I *think* the call to request() has to be before releasing the GIL. + // I *think* the call to request() in numpy_to_range_of_pairs has to be before releasing the GIL. auto diag1 = numpy_to_range_of_pairs(d1, make_point); auto diag2 = numpy_to_range_of_pairs(d2, make_point); diff --git a/src/python/gudhi/hera/wasserstein.cc b/src/python/gudhi/hera/wasserstein.cc index 8c731530..77c1413a 100644 --- a/src/python/gudhi/hera/wasserstein.cc +++ b/src/python/gudhi/hera/wasserstein.cc @@ -27,7 +27,7 @@ py::object wasserstein_distance( double wasserstein_power, double internal_p, double delta, bool return_matching) { - // I *think* the call to request() has to be before releasing the GIL. + // I *think* the call to request() in numpy_to_range_of_pairs has to be before releasing the GIL. auto diag1 = numpy_to_range_of_pairs(d1, make_hera_point); auto diag2 = numpy_to_range_of_pairs(d2, make_hera_point); int n1 = boost::size(diag1); |