summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVincent Rouvreau <vincent.rouvreau@inria.fr>2022-01-19 09:50:13 +0100
committerVincent Rouvreau <vincent.rouvreau@inria.fr>2022-01-19 09:50:13 +0100
commit72a56067c5a6f105ff60996e7257063505030e73 (patch)
treeca8f8749c5df8eafbeaac28e1ec3906fe3b5e626
parent5c09f30e85aa8c50f686265c12987945f0e0a618 (diff)
Code review: exact_version was useless in Inexact_alpha_complex_dD
-rw-r--r--src/python/include/Alpha_complex_factory.h14
-rw-r--r--src/python/include/Alpha_complex_interface.h4
2 files changed, 7 insertions, 11 deletions
diff --git a/src/python/include/Alpha_complex_factory.h b/src/python/include/Alpha_complex_factory.h
index 8f820fc9..14ec1f86 100644
--- a/src/python/include/Alpha_complex_factory.h
+++ b/src/python/include/Alpha_complex_factory.h
@@ -118,15 +118,12 @@ class Inexact_alpha_complex_dD final : public Abstract_alpha_complex {
typename Kernel::Point_d>;
public:
- Inexact_alpha_complex_dD(const std::vector<std::vector<double>>& points, bool exact_version)
- : exact_version_(exact_version),
- alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal<Bare_point>)) {
+ Inexact_alpha_complex_dD(const std::vector<std::vector<double>>& points)
+ : alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal<Bare_point>)) {
}
- Inexact_alpha_complex_dD(const std::vector<std::vector<double>>& points,
- const std::vector<double>& weights, bool exact_version)
- : exact_version_(exact_version),
- alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal<Bare_point>), weights) {
+ Inexact_alpha_complex_dD(const std::vector<std::vector<double>>& points, const std::vector<double>& weights)
+ : alpha_complex_(boost::adaptors::transform(points, pt_cython_to_cgal<Bare_point>), weights) {
}
virtual std::vector<double> get_point(int vh) override {
@@ -135,11 +132,10 @@ class Inexact_alpha_complex_dD final : public Abstract_alpha_complex {
}
virtual bool create_simplex_tree(Simplex_tree_interface<>* simplex_tree, double max_alpha_square,
bool default_filtration_value) override {
- return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, exact_version_, default_filtration_value);
+ return alpha_complex_.create_complex(*simplex_tree, max_alpha_square, false, default_filtration_value);
}
private:
- bool exact_version_;
Alpha_complex<Kernel, Weighted> alpha_complex_;
};
diff --git a/src/python/include/Alpha_complex_interface.h b/src/python/include/Alpha_complex_interface.h
index ed243f19..188036ed 100644
--- a/src/python/include/Alpha_complex_interface.h
+++ b/src/python/include/Alpha_complex_interface.h
@@ -34,9 +34,9 @@ class Alpha_complex_interface {
const bool weighted = (weights.size() > 0);
if (fast_version) {
if (weighted) {
- alpha_ptr_ = std::make_unique<Inexact_alpha_complex_dD<true>>(points, weights, exact_version);
+ alpha_ptr_ = std::make_unique<Inexact_alpha_complex_dD<true>>(points, weights);
} else {
- alpha_ptr_ = std::make_unique<Inexact_alpha_complex_dD<false>>(points, exact_version);
+ alpha_ptr_ = std::make_unique<Inexact_alpha_complex_dD<false>>(points);
}
} else {
if (weighted) {